Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor retdata macro to not require import of the type #1464

Merged
merged 1 commit into from
Oct 23, 2024
Merged

chore: refactor retdata macro to not require import of the type #1464

merged 1 commit into from
Oct 23, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@lotem-starkware
Copy link
Contributor

This change is Reviewable

@ArniStarkware ArniStarkware mentioned this pull request Oct 20, 2024
Closed
@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Oct 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

This was referenced Oct 20, 2024
Merged
Merged
Closed
@ArniStarkware ArniStarkware marked this pull request as ready for review October 20, 2024 05:13
@codecov Codecov
Copy link

codecov bot commented Oct 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.46%. Comparing base (b0cfe82) to head (1e2fe53).
Report is 495 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (1e2fe53). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (1e2fe53)
3 1
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1464       +/-   ##
===========================================
- Coverage   74.18%   58.46%   -15.73%     
===========================================
  Files         359      143      -216     
  Lines       36240    17954    -18286     
  Branches    36240    17954    -18286     
===========================================
- Hits        26886    10497    -16389     
+ Misses       7220     6751      -469     
+ Partials     2134      706     -1428
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/calldata branch from 5d84954 to 113ef96 Compare October 20, 2024 07:26
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/retdata branch from 9e7e9a5 to 64818a3 Compare October 20, 2024 07:26
@elintul elintul removed their request for review October 20, 2024 13:48
MohammadNassar1
MohammadNassar1 approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dorimedini-starkware)

a discussion (no related file):
Why it's not over main branch?

@ArniStarkware
Copy link
Contributor Author

Previously, MohammadNassar1 (mohammad-starkware) wrote…

Why it's not over main branch?

To avoid conflicts with myself.

@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/calldata branch from 113ef96 to ab8bd98 Compare October 21, 2024 06:18
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/retdata branch from 64818a3 to f3ce6d4 Compare October 21, 2024 06:18
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/calldata branch from ab8bd98 to 2ec9fc6 Compare October 21, 2024 06:55
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/retdata branch from f3ce6d4 to ad2a114 Compare October 21, 2024 06:55
@ArniStarkware ArniStarkware changed the base branch from arni/self_contained_macros/calldata to graphite-base/1464 October 21, 2024 08:01
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/retdata branch from ad2a114 to 630a50a Compare October 21, 2024 08:01
@ArniStarkware ArniStarkware changed the base branch from graphite-base/1464 to main October 21, 2024 08:01
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/retdata branch from 630a50a to b394585 Compare October 21, 2024 08:02
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/retdata branch from b394585 to 1e2fe53 Compare October 21, 2024 16:15
MohammadNassar1
MohammadNassar1 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@ArniStarkware ArniStarkware merged commit bbecffb into main Oct 23, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
@ArniStarkware ArniStarkware deleted the arni/self_contained_macros/retdata branch October 26, 2024 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MohammadNassar1 MohammadNassar1 MohammadNassar1 approved these changes

@dorimedini-starkware dorimedini-starkware Awaiting requested review from dorimedini-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArniStarkware @lotem-starkware @MohammadNassar1